CI: Fix Coverage Analysis. #73029
Merged
CI: Fix Coverage Analysis. #73029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arikgreen
requested changes
May 21, 2024
| @@ -274,7 +274,8 @@ def generate_json_report(self, coverage): | |||
| "Name":i_fun['name'] | |||
| } | |||
| json_file['Uncovered_Functions'].append(json_uncovered_funciton) | |||
| json_files.append(json_file) | |||
| if not self.is_duplicate(json_file, json_files): | |||
There was a problem hiding this comment.
Suggested change
| if not self.is_duplicate(json_file, json_files): | |
| comp_exists = [x for x in json_files if x['Name'] == json_file['Name']] | |
| if not comp_exists: |
gbarkadiusz
force-pushed
the
topic/ci/fix_coverage_analysis
branch
from
de76d2a
to
6b9763c
Compare
|
@arikgreen Please take a look again. |
arikgreen
previously approved these changes
May 21, 2024
gbarkadiusz
force-pushed
the
topic/ci/fix_coverage_analysis
branch
from
6b9763c
to
5aaeb9c
Compare
arikgreen
approved these changes
May 22, 2024
nashif
approved these changes
May 28, 2024
The coverage_analysis.py while generating report, duplicates files and functions of components. Signed-off-by: Arkadiusz Cholewinski <arkadiuszx.cholewinski@intel.com>
nashif
force-pushed
the
topic/ci/fix_coverage_analysis
branch
from
5aaeb9c
to
a60e283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: The coverage_analysis.py while generating report, duplicates some files and functions of components.
e.g for bluetooth.
After the fix.
