-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: tester: Fix assert in OTS #73017
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick, Bluetooth with a B in the commit tittle?
Arguably it should also be Not sure if we actually have any proper guidelines for this though |
|
MCS OTS support doesn't implement OTS checksum and if this is globally enabled assert is triggered. [00:00:03.409,484] <dbg> bttester_gap: set_io_cap: io_cap: 0 ASSERTION FAIL [ots_init->cb->obj_cal_checksum] @ WEST_TOPDIR/zephyr/subsys/bluetooth/services/ots/ots.c:476 Callback for object calculate checksum is not set This should be reverted when Zephyr issue zephyrproject-rtos#72471 is fixed. Signed-off-by: Szymon Janc <szymon.janc@codecoup.pl>
MCS OTS support doesn't implement OTS checksum and if this is globally enabled assert is triggered.
[00:00:03.409,484] bttester_gap: set_io_cap: io_cap: 0 ASSERTION FAIL [ots_init->cb->obj_cal_checksum]
@ WEST_TOPDIR/zephyr/subsys/bluetooth/services/ots/ots.c:476
Callback for object calculate checksum is not set
This should be reverted when Zephyr issue #72471 is fixed.