Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivers: video: Move the sensors to their dedicated directory #73013

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josuah
Copy link
Collaborator

@josuah josuah commented May 20, 2024

This allows to have a more immediate insight of the different kinds of video drivers present in this directory, as well as help maintenance of a whole group at once i.e. during refactors.

I still need to test building it and run it on hardware...

I understand that these kind of modifications might not be desired for backward compatibility reasons, or avoid breaking ongoing pull requests.

@josuah josuah marked this pull request as draft May 20, 2024 09:45
@zephyrbot zephyrbot added the area: Video Video subsystem label May 20, 2024
@loicpoulain
Copy link
Collaborator

Now we have more drivers, maybe we should have a sensor subdir instead?

@josuah josuah force-pushed the pr-drivers-video-sensor-prefix branch from a3f6020 to ce289c7 Compare May 21, 2024 03:22
@josuah josuah changed the title drivers: video: give a common prefix to all the video sensors drivers: video: Move the sensors to their dedicated directory May 23, 2024
loicpoulain
loicpoulain previously approved these changes May 31, 2024
This is meant to clearly identify all sensors and facilitate grouped
maintenace of all sensors.

This also updates the layout of the Kconfig and CMakeLists.txt to
how it is done to the root level Kconfig/CMakeLists.txt.

Signed-off-by: Josuah Demangeon <me@josuah.net>
@josuah
Copy link
Collaborator Author

josuah commented May 31, 2024

Thank you taking the time to review! I will fix the conflicts and other CI issues, rebase, and wait that the few ongoing video driver PRs are merged to reduce friction then apply the exact same changes to the new drivers, and finally un-draft it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Video Video subsystem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants