Capture qemu launch stdout and stderr #72998
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
gchwier,
golowanow,
gopiotr,
hakehuang,
KamilxPaszkiet,
LukaszMrugala,
nashif and
PerMac
nashif
approved these changes
May 21, 2024
|
@kuikka please fix the commit message |
Currently we launch qemu (well, "ninja run" usually) using Popen and request stdout and stderr to be redirected into a pipe. However we never read that pipe so the information is not captured. Instead log directly into files that can be inspected after a failed to to find out why qemu run failed. Note that this is really only useful in cases where qemu either fails to launch or crashes. Regular test data is still handled via the qemu fifo. Signed-off-by: Juha Kuikka <juha.kuikka@gmail.com>
Should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we launch qemu (well, "ninja run" usually) using Popen and request stdout and stderr to be redirected into a pipe. However we never read that pipe so the information is not captured. Instead log directly into files that can be inspected after a failed to to find out why qemu run failed.
Note that this is really only useful in cases where qemu either fails to launch or crashes.
Regular test data is still handled via the qemu fifo.
Fixes #72997