TypeScript declarations + clownface-shacl-path #121
Conversation
🦋 Changeset detectedLatest commit: adf47e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "rdf-validate-shacl": patch | ||
| --- | ||
|
|
||
| Use [clownface-shacl-path](https://npm.im/clownface-shacl-path) for path traversals |
There was a problem hiding this comment.
This can have an unknown impact on performance which needs to be checked.
@ludovicm67, do you have an idea for a GH workflow job which would measure the time of a large dataset being validated so that we can compare if a PR does not decrease performance? I found https://github.com/benchmark-action/github-action-benchmark but it's not exactly what I have in mind
There was a problem hiding this comment.
@tpluscode no, I don't have any idea yet for this.
If I found something relevant, I will share it with you :)
There was a problem hiding this comment.
Actually, later yesterday I found a fork which should be more useful for PRs: https://github.com/openpgpjs/github-action-pull-request-benchmark
They simply check out master and PR branches and compare results. WDYT?
There was a problem hiding this comment.
I don't have any strong opinion on the tool to use for this topic, I would suggest that you go with it, and it in the future we find anything better, we can always do a switch.
Regarding the fork you mention, it seems to be a bit more dedicated for PR and compare with the default branch.
No description provided.