added copy options rules feature

[aayushhyadav]

related to #7767

[psiinon]

Will the Duplicate option be valid for all such dialogs?
Might be better to have an allowDuplication option (as per allowModification) with the default as false.
That way we can enable it per dialog and then double check it works.
We dont really have any UI unit tests so we'd need to manually test these anyway...

[aayushhyadav]

So will have to update AbstractMultipleOptionsBaseTablePanel( AbstractMultipleOptionsBaseTableModel<E> model, boolean allowModification) by adding another parameter of allowduplicate right? This currently has 3 usages, so do you mean that I should pass false from all 3 instances?

[aayushhyadav]

Any idea how to resolve the build issue? I have tried to clean and build the project but the issue persists.

[thc202]

You need to keep binary compatibility, e.g. add a new constructor instead of changing that one.

[aayushhyadav]

Will the Duplicate option be valid for all such dialogs? Might be better to have an allowDuplication option (as per allowModification) with the default as false. That way we can enable it per dialog and then double check it works. We dont really have any UI unit tests so we'd need to manually test these anyway...

I have added the allowDuplication option and passed the same value as that of allowModification at all instances

[aayushhyadav]

You need to keep binary compatibility, e.g. add a new constructor instead of changing that one.

I am trying to add something like protected AbstractMultipleOptionsBaseTablePanel(boolean allowDuplicate). From where should I invoke this constructor? I cannot use the this(false) from public AbstractMultipleOptionsBaseTablePanel(AbstractMultipleOptionsBaseTableModel<E> model) or protected AbstractMultipleOptionsBaseTablePanel(AbstractMultipleOptionsBaseTableModel<E> model, boolean allowModification) as they already use this and super respectively.

[aayushhyadav]

One more query, can't we use the allowModification flag for duplicate functionality? So duplicate will only be available when modify is present. Or is it necessary to have them independent of each other?

[kingthorin]

They should be independent. There may be situations where modifying one is fine but duplicating isn’t and vice versa.

[thc202]

#7783 (comment)

You can change the implementation of the existing constructors just not their signature.

[aayushhyadav]

#7783 (comment)

You can change the implementation of the existing constructors just not their signature.

Is the current approach fine?

[thc202]

See #7783 (comment)

[aayushhyadav]

Could anyone please review the changes? Are anymore changes required?