Skip to content

Commit

Permalink
Revert "[Fixes GeoNode#12167] providing multiple openid_connect djang…
Browse files Browse the repository at this point in the history
…o.allauth socialproviders fails when loading login page"

This reverts commit 3e9d489.
  • Loading branch information
mwallschlaeger committed Apr 18, 2024
1 parent 3a3f2e9 commit 2ff52e6
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions geonode/people/adapters.py
Original file line number Diff line number Diff line change
Expand Up @@ -267,12 +267,7 @@ def get_provider(self, request=None, provider=None):
provider = provider or self.provider_id
provider_class = registry.get_class(provider)
if provider_class is None or provider_class.uses_apps:
# check if first app provider contains client_id, mutiple apps in a single provider
# get seperated into multiple providers, an this function gets called multiple times
# https://github.com/pennersr/django-allauth/blob/main/docs/socialaccount/providers/openid_connect.rst
if not self.list_apps(request)[0].client_id:
raise (ImproperlyConfigured(f"Missing client_id parameter in provider: {provider} configuration"))
app = self.get_app(request, provider=provider, client_id=self.list_apps(request)[0].client_id)
app = self.get_app(request, provider=provider)
if not provider_class:
# In this case, the `provider` argument passed was a
# `provider_id`.
Expand Down

0 comments on commit 2ff52e6

Please sign in to comment.