Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic support for PROXY protocol V2 for TCP backends #280

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

xabinapal
Copy link

@xabinapal xabinapal commented May 17, 2020

I have made some improvements over the work done in PR #101 to add basic support for PROXY protocol V2 in TCP backends.

At the moment, it can only add the minimum header required to implement this protocol, but it can not set any TLV extension, as the underlying library used to create the header does not support this operation. I'll try to submit a PR to this library and, if it gets merged, I'll add configuration parameters to customize what TLVs are sent (such as SSL options). With this feature in mind, I have also allowed TLS listeners to send PROXY headers to their respective upstreams, so this protocol can be used in TLS termination scenarios.

Finished work

  • Add support for PROXY Protocol V2
  • Allow TLS listeners to use PROXY Protocol in their upstreams
  • Tests for PROXY Protocol V1 and V2, both with IPv4 and IPv6 connections

Pending work

  • Allow UDP connections to send PROXY Protocol V2
  • Include extra TLVs in PROXY Protocol V2 headers, such as SSL

@illarion illarion added this to the Selected for development milestone Jul 7, 2020
@illarion illarion marked this pull request as draft July 7, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants