Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: explain a workaround for if with typed children #3560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctron
Copy link
Contributor

@ctron ctron commented Dec 13, 2023

Description

Explains a workaround for #3256

Checklist

  • I have reviewed my own code

@ctron ctron force-pushed the feature/doc_if_type_1 branch 2 times, most recently from f4b1769 to 1d5f226 Compare December 13, 2023 08:53
Copy link

github-actions bot commented Dec 13, 2023

Visit the preview URL for this PR (updated for commit 23debb4):

https://yew-rs--pr3560-feature-doc-if-type-hu7h7tdk.web.app

(expires Wed, 20 Dec 2023 09:24:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ctron
Copy link
Contributor Author

ctron commented Dec 19, 2023

Is there something missing for this PR? It's a doc only change and should be quick to merge.

@futursolo
Copy link
Member

futursolo commented Dec 19, 2023

Thank you for your pull request.

However, I do not think this pull request will be accepted due to the issue with typed children and ChildrenRenderer itself, which is discussed in detail in #3256 and #3262.
As a result, we have committed to remove Children* from most examples and no longer recommend their usage.

You can try out a slightly modified version of the code you submitted in:
https://play.yew.rs/?shared=j98egT98b67VRJAGJIJu

2023-12-19.18.32.11.mov

The correct behaviour should be the input containing 3 being removed and added, however, input 1 is being toggled instead.

@ctron
Copy link
Contributor Author

ctron commented Dec 19, 2023

So, what's the strategy on having type safe children in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants