-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tests): use 'urllib.request' instead of 'requests' #1185
base: develop
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 90.46% // Head: 90.46% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #1185 +/- ##
========================================
Coverage 90.46% 90.46%
========================================
Files 181 181
Lines 5514 5514
========================================
Hits 4988 4988
Misses 526 526
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
45b1d80
to
a0dddb9
Compare
@rivanfebrian123 Thank you so much for your time on this! It's very appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please rebase from develop
? Some changes has been merged yesterday and they are not into your branch yet apparently.
Apart from that, it looks good. Thanks again!
9252208
to
3123047
Compare
Ah... good to know
Actually, it wasn't possible to rebase as there was a merge conflict. So I revert commits in the branch and force-push instead. But don't worry, we're good to go now |
e786ac6
to
2d55f32
Compare
6ba2217
to
ef023c3
Compare
4500563
to
cfb020d
Compare
Following #1177