Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): use 'urllib.request' instead of 'requests' #1185

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

stormbeforesunsetbee
Copy link
Contributor

Following #1177

@codecov-commenter
Copy link

Codecov Report

Base: 90.46% // Head: 90.46% // No change to project coverage 👍

Coverage data is based on head (9252208) compared to base (37867a4).
Patch coverage: 90.90% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1185   +/-   ##
========================================
  Coverage    90.46%   90.46%           
========================================
  Files          181      181           
  Lines         5514     5514           
========================================
  Hits          4988     4988           
  Misses         526      526           
Flag Coverage Δ
py3.8-ubuntu-latest-pandas 90.46% <90.90%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/issues/test_issue377.py 82.60% <50.00%> (ø)
src/pandas_profiling/utils/cache.py 100.00% <100.00%> (ø)
tests/issues/test_issue537.py 94.59% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aquemy
Copy link
Contributor

aquemy commented Nov 30, 2022

@rivanfebrian123 Thank you so much for your time on this! It's very appreciated.

Copy link
Contributor

@aquemy aquemy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase from develop? Some changes has been merged yesterday and they are not into your branch yet apparently.

Apart from that, it looks good. Thanks again!

@stormbeforesunsetbee
Copy link
Contributor Author

Some changes has been merged yesterday and they are not into your branch yet apparently.

Ah... good to know

Could you please rebase from develop?

Actually, it wasn't possible to rebase as there was a merge conflict. So I revert commits in the branch and force-push instead. But don't worry, we're good to go now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants