Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] Properly close popups for nested progress callbacks (bsc#1223281) #1311

Merged
merged 6 commits into from
May 9, 2024
Merged

[master] Properly close popups for nested progress callbacks (bsc#1223281) #1311

merged 6 commits into from
May 9, 2024

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented May 7, 2024

@coveralls
Copy link

coveralls commented May 7, 2024 •
edited

Coverage Status

coverage: 41.887%. remained the same
when pulling 415230c on close_progress_popups_master
into 8f60c6c on master.

@lslezak lslezak requested a review from mchf May 9, 2024 06:53
@lslezak
Copy link
Member Author

lslezak commented May 9, 2024

@mchf is it OK to backport of the journalctl fix from SP6 to master?

mchf
mchf approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@mchf mchf left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, it is ok to backport it to the master. The fix was requested (#970) way before SP6 was with us anyway.

Thanks

@lslezak lslezak merged commit b49143a into master May 9, 2024
12 checks passed
@lslezak lslezak deleted the close_progress_popups_master branch May 9, 2024 09:15
@yast-bot
Copy link
Contributor

yast-bot commented May 9, 2024

✔️ Internal Jenkins job #230 successfully finished
✔️ Created OBS submit request #1172895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchf mchf mchf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lslezak @coveralls @yast-bot @mchf