Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly close popups for nested progress callbacks (bsc#1223281) #1309

Merged
merged 1 commit into from
May 7, 2024

Conversation

lslezak
Copy link
Member

@lslezak lslezak commented May 6, 2024

Problem

no_widget_error

Details

  • The problem happens only when the self-update is enabled, with disabled self-update it works fine
  • It turned out that with updated libzypp the start and end callbacks are called twice:
modules/PackageCallbacks.rb(ProgressStart):2338 ProgressStart: 992
modules/PackageCallbacks.rb(ProgressStart):2338 ProgressStart: 992
modules/PackageCallbacks.rb(ProgressEnd):2391 ProgressFinish: 992
modules/PackageCallbacks.rb(ProgressEnd):2391 ProgressFinish: 992
  • The code is actually prepared for this situation, it counts the nesting level for the start and end calls
  • But unfortunately there was a bug when closing the nested callback, it closed only one (the last) popup

Solution

  • Properly close the open popup when there are nested callbacks (multiple open popups)

Testing

  • Tested manually
  • All popups are closed, the workflow properly continues to the next step

@coveralls
Copy link

Coverage Status

coverage: 41.763%. remained the same
when pulling 7812c96 on close_progress_popups_sp5
into f654b71 on SLE-15-SP5.

Copy link
Contributor

@joseivanlopez joseivanlopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit b545c04 into SLE-15-SP5 May 7, 2024
12 checks passed
@lslezak lslezak deleted the close_progress_popups_sp5 branch May 7, 2024 07:48
@yast-bot
Copy link
Contributor

yast-bot commented May 7, 2024

✔️ Internal Jenkins job #6 successfully finished
✔️ Created IBS submit request #329372

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants