Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Host / Domain Names starting with an Underscore [master] #1303

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

shundhammer
Copy link
Contributor

Target Branch

This is the merge PR for master of PR #1301 / PR #1302.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1219920

Problem

Modern DNS setups require using a leading underscore for hostnames in some situations, e.g. _mydomain.example.com. But that is not possible to enter in the YaST DNS Server module: Underscores are generally rejected.

Fix

Allow a leading underscore for host and domain names. Not just anywhere, just as the leading character.

Since the check is in Hostname.rb which belongs to the yast2 package (repo yast-yast2), this is not in the yast2-dns-server package where it might be expected.

Known Limitation

This allows a leading underscore for all components of a FQDN in all circumstances. Users need to have some expertise to know when that is suitable.

The Error Message

The error message quoted in the bug remains the same; we are not changing it, so not all translations will be broken, resulting in purely English error messages for all international users. The message does not contain anything about the leading underscore. But the message should not appear when this is used correctly.

Screenshot

yast-dns-server

Notice that leading underscores are now allowed, while underscores in other places are not.

Testing

Manual testing with sudo yast2 dns-server after a manual sudo rake install.

Reference

Related PRs

@coveralls
Copy link

Coverage Status

coverage: 41.887% (+0.008%) from 41.879%
when pulling 6e29230 on huha-hostname-master
into e734000 on master.

Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shundhammer shundhammer merged commit 72674ce into master Feb 15, 2024
12 checks passed
@shundhammer shundhammer deleted the huha-hostname-master branch February 15, 2024 13:44
@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #228 successfully finished
✔️ Created OBS submit request #1147374

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants