User creation page got messed when going back after importing user(s) from existing installation #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5656085602
💛 - Coveralls |
mchf
force-pushed
the
bsc1211583-import-users-fail
branch
from
e1b1a7c
to
54d62ce
Compare
mchf
force-pushed
the
bsc1211583-import-users-fail
branch
from
2d9ee31
to
d97a66b
Compare
mchf
force-pushed
the
bsc1211583-import-users-fail
branch
from
d97a66b
to
154768d
Compare
|
✔️ Internal Jenkins job #750 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Reporter imported a user from existing system during installation. Later on walked back and the user creation dialog's password field was messed with incredibly long password. Most probably hashed password got in use.
Solution
Dialog tries to determine whether a user was already imported when walking back. If yes it disables manual definition part of the dialog and enables importing user
Testing