new rubocop: manual fixes

.rubocop.yml

@@ -3,17 +3,27 @@ inherit_from:
   /usr/share/YaST2/data/devtools/data/rubocop-1.24.1_yast_style.yml
 
 # Don't enforce any particular name for block params
-SingleLineBlockParams:
+Style/SingleLineBlockParams:
   Enabled: false
 
 Style/FrozenStringLiteralComment:
   Enabled: false
 
+Metrics/AbcSize:
+  Max: 40
+
+Metrics/CyclomaticComplexity:
+  Max: 10
+
 Metrics/BlockLength:
   # rspec is known as DSL with big blocks
   Exclude:
     - test/**/*
 
+# do not break API
+Naming/MethodParameterName:
+  Enabled: false
+
 AllCops:
   Exclude:
     - 'src/modules/**/*'

src/lib/users/clients/auto.rb

@@ -19,14 +19,13 @@
 
 require "yast"
 require "installation/auto_client"
+require "y2issues"
 require "y2users"
 require "y2users/autoinst/reader"
-require "y2issues"
-require "y2users/config_merger"
 require "y2users/config_manager"
-require "y2users/autoinst/reader"
-require "y2users/users_module/reader"
+require "y2users/config_merger"
 require "y2users/linux/writer"
+require "y2users/users_module/reader"
 
 Yast.import "Users"
 Yast.import "Linuxrc"
@@ -41,6 +40,7 @@ module Clients
     # AutoYaST users client
     class Auto < ::Installation::AutoClient
       def initialize
+        super
         textdomain "users"
 
         Yast.include self, "users/wizards.rb"

src/lib/users/clients/users_finish.rb

@@ -37,6 +37,7 @@ class UsersFinishClient < ::Installation::FinishClient
     include Logger
 
     def initialize
+      super
       textdomain "users"
 
       Yast.import "Users"

src/lib/users/dialogs/inst_root_first.rb

@@ -33,6 +33,7 @@ class InstRootFirstDialog < ::CWM::Dialog
     #
     # @param root_user [Y2Users::Users] object holding the root user configuration
     def initialize(root_user)
+      super()
       textdomain "users"
 
       @root_user = root_user

src/lib/users/encryption_proposal.rb

@@ -26,6 +26,7 @@ class EncryptionProposal < ::Installation::ProposalClient
     include Yast::Logger
 
     def initialize
+      super
       Yast.import "Wizard"
       textdomain "users"
     end

src/lib/users/proposal.rb

@@ -29,6 +29,7 @@ class Proposal < ::Installation::ProposalClient
     include Yast::Logger
 
     def initialize
+      super
       Yast.import "Wizard"
       Yast.import "Mode"
       textdomain "users"

src/lib/users/ssh_authorized_keys_file.rb

@@ -100,9 +100,12 @@ def keys=(new_keys)
       keys
     end
 
+    # it is not our regexp
+    # rubocop:disable Lint/MixedRegexpCaptureTypes
     # https://github.com/puppetlabs/puppet/blob/master/lib/puppet/type/ssh_authorized_key.rb#L138
     AUTHORIZED_KEYS_REGEX =
       /\A(?<env>(.+)\s+)?(?<type>(ssh|ecdsa)-\S+)\s+(?<key>[^ ]+)\s*(?<comment>.*)\z/.freeze
+    # rubocop:enable Lint/MixedRegexpCaptureTypes
 
     # Determine is a string qualifies like a valid key
     #

src/lib/users/widgets.rb

@@ -51,6 +51,7 @@ class << self
     # @param focus [Boolean] if set, then widget set focus to first password input field
     # @param allow_empty [Boolean] whether the user can left the password empty or not
     def initialize(user, little_space: false, focus: false, allow_empty: false)
+      super()
       textdomain "users"
 
       @user = user

src/lib/users/widgets/inst_root_first.rb

@@ -31,6 +31,7 @@ class InstRootFirst < ::CWM::CustomWidget
       #
       # @param user [Y2Users::User] the root user to work with
       def initialize(user)
+        super()
         textdomain "users"
 
         @user = user

src/lib/users/widgets/public_key_selector.rb

@@ -40,6 +40,7 @@ class << self
       #
       # @param user [Y2Users::User] the user to work with
       def initialize(user)
+        super()
         textdomain "users"
 
         @user = user

src/lib/y2users/autoinst_profile/groups_section.rb

@@ -41,6 +41,7 @@ def new_from_hashes(hashes)
       end
 
       def initialize(groups = [])
+        super()
         @groups = groups
       end
 

src/lib/y2users/autoinst_profile/users_section.rb

@@ -40,6 +40,7 @@ def new_from_hashes(hashes)
       end
 
       def initialize(users = [])
+        super()
         @users = users
       end
 

src/lib/y2users/config_element_collection.rb

@@ -26,7 +26,7 @@ class ConfigElementCollection < Collection
     #
     # @param elements [Array<ConfigElement>]
     def initialize(elements = [])
-      @elements = elements
+      super
     end
 
     # Deletes the element with the given id from the collection

src/lib/y2users/linux/groups_writer.rb

@@ -42,6 +42,7 @@ class GroupsWriter < ActionWriter
       # @param initial_config [Config] see #initial_config
       # @param commit_config [CommitConfig] see #commit_config
       def initialize(target_config, initial_config, commit_config)
+        super()
         textdomain "users"
 
         @initial_config = initial_config

src/lib/y2users/linux/local_reader.rb

@@ -27,6 +27,7 @@ class LocalReader < BaseReader
       #
       # @param source_dir [String, Pathname] path of source directory for reading files
       def initialize(source_dir = "/")
+        super()
         @source_dir = source_dir
       end
 

src/lib/y2users/linux/users_writer.rb

@@ -53,6 +53,7 @@ class UsersWriter < ActionWriter
       # @param initial_config [Config] see #initial_config
       # @param commit_config [CommitConfig]
       def initialize(target_config, initial_config, commit_config)
+        super()
         textdomain "users"
 
         @initial_config = initial_config

src/lib/y2users/password.rb

@@ -176,6 +176,7 @@ class PasswordValue < ShadowField
     #
     # @param content [String] password value
     def initialize(content)
+      super()
       self.content = content
     end
 

test/dialogs_test.rb

@@ -6,6 +6,7 @@
 
 class UsersDialogsDummy < Yast::Module
   def initialize
+    super
     Yast.include self, "users/dialogs.rb"
   end
 end

test/fixtures/users_export.rb

@@ -273,7 +273,8 @@
                         "shell"                => "/bin/bash",
                         "uid"                  => "1000",
                         "user_password"        => "$6$Jn1sSsaWb5Jj$97bMFbWPGB5UgE/Vt7uuUMjLPIW4C" \
-                                                  "7McyvXxkyltK/0GgW0Q7qG6F0eKeVLYziskSihzlakgXUG1gPRw/ZKw10",
+                                                  "7McyvXxkyltK/0GgW0Q7qG6F0eKeVLYziskSihzlakgXU" \
+                                                  "G1gPRw/ZKw10",
                         "username"             => "tux" },
                       { "authorized_keys"      => [],
                         "encrypted"            => true,
@@ -386,7 +387,8 @@
                         "shell"                => "/bin/bash",
                         "uid"                  => "0",
                         "user_password"        => "$6$ASfaLE9EGIam$Gk9YxWfX/EeB8sEv3qLYdHQXTx.9T" \
-                                                  "1wNoyn5Y34PMZ03wh8S48QhbpjC8gUQvdFnbdH.4HqGeT3z5Y2zdlM11/",
+                                                  "1wNoyn5Y34PMZ03wh8S48QhbpjC8gUQvdFnbdH.4HqGeT" \
+                                                  "3z5Y2zdlM11/",
                         "username"             => "root" },
                       { "authorized_keys"      => [],
                         "encrypted"            => true,
@@ -547,7 +549,8 @@
                         "shell"                => "/bin/bash",
                         "uid"                  => "0",
                         "user_password"        => "$6$ASfaLE9EGIam$Gk9YxWfX/EeB8sEv3qLYdHQXTx.9T1" \
-                                                  "wNoyn5Y34PMZ03wh8S48QhbpjC8gUQvdFnbdH.4HqGeT3z5Y2zdlM11/",
+                                                  "wNoyn5Y34PMZ03wh8S48QhbpjC8gUQvdFnbdH.4HqGeT3z" \
+                                                  "5Y2zdlM11/",
                         "username"             => "toor" },
                       { "authorized_keys"      => [],
                         "encrypted"            => true,

test/lib/users/widgets/inst_root_first_test.rb

@@ -52,9 +52,6 @@
     end
 
     context "when neither a password nor public key was given" do
-      before do
-      end
-
       it "returns false" do
         expect(widget.validate).to eq(false)
       end