Proposal: Unit test to showcase a serious bug #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Consider a system that initially contains an MS-DOS partition table and partitions are deleted one by one during the proposal process to the point in which the partition table is empty.
Then the proposal will take the opportunity to replace that empty MS-DOS partition table with a GPT one (which is the default)... but it doesn't re-calculate the partitions needed for booting.
The problem is not new. This test fails in several branches (SLE-15-SP5, SLE-15-SP6 and master at the time I tested).
Solution
To be implemented (before merging this, of course).