Optionally include the encryption status in the device description

[lslezak]

Problem

• The device labels in Agama do not include the encryption status
• In YaST it is OK because it has a dedicated column with encryption status
• In Agama we would like to have the status included directly in the label

Solution

• Adapt the code to include the encryption status in the label

Notes

• The encryption status is included only when explicitly requested. That allows to keep the backward compatibility with YaST and show it only in Agama.
• See related Include the encryption status in the device description openSUSE/agama#1155

Testing

• Tested manually

Screenshots

[lslezak]

Questions

• Is this the right approach?
• Which devices can be actually encrypted?
• Should we check the encryption status for all kinds of devices or are there some cases where it does not make sense or is not supported? It could save some work for the translators...

[coveralls]

coverage: 97.801% (-0.01%) from 97.815%
when pulling 60927eb on encrypted_device_label
into 600ef23 on master.

[joseivanlopez]

Questions

• Is this the right approach?

I think it is a valid approach.

• Which devices can be actually encrypted?

All block devices could be encrypted, even logical volumes (Disk, Partition, Md, LvmPv, LvmLv, etc).

• Should we check the encryption status for all kinds of devices or are there some cases where it does not make sense or is not supported? It could save some work for the translators...

In DeviceDescription there are two "branches": #formatted_device_type_label and unformatted_device_type_label. This PR covers the first branch, but I think we should add "Encryption" also in the cases of unformatted devices (e.g., "Encrypted PV of %s").

[lslezak]

In DeviceDescription there are two "branches": #formatted_device_type_label and unformatted_device_type_label. This PR covers the first branch, but I think we should add "Encryption" also in the cases of unformatted devices (e.g., "Encrypted PV of %s").

Yes, this first commit was just a PoC and first I wanted to get the answer for the question about which devices can be encrypted. I'll add it in the following commit(s).

[dgdavid]

• In YaST it is OK because it has a dedicated column with encryption status
• In Agama we would like to have the status included directly in the label

Just thinking aloud: YaST could benefit from this approach too.

[lslezak]

Possibly yes, but that's currently out of scope...

[joseivanlopez]

LGTM

[yast-bot]

✔️ Internal Jenkins job #1154 successfully finished
✔️ Created OBS submit request #1168841