Experimental rubocop #1364
Draft
Experimental rubocop #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
force-pushed
the
experimental_rubocop
branch
from
69bcb6b
to
c003d57
Compare
jreidinger
commented
Jan 4, 2024
| @@ -619,7 +619,7 @@ def use_value_from_string(use) | |||
| # nil if the root filesystem is not applicable. | |||
| def enabled_snapshots?(filesystems) | |||
| root_fs = filesystems.find(&:root?) | |||
| return nil if root_fs.nil? || (root_fs.multidevice? && !btrfs_drive_section?) | |||
| return false if root_fs.nil? || (root_fs.multidevice? && !btrfs_drive_section?) | |||
There was a problem hiding this comment.
and this cause several test failures. I am not sure if it is correct change. On one hand it is ? method, but nil is documented there. Also not sure if it is common in storage or one single occurrence.
lslezak
reviewed
Feb 1, 2024
| @@ -247,7 +247,7 @@ def partition_candidate_spaces(partition, candidate_spaces, extra_spaces) | |||
| # | |||
| # @return [Boolean] | |||
| def compatible_disk?(partition, space) | |||
| return true unless partition.disk && partition.disk != space.disk_name | |||
| true unless partition.disk && partition.disk != space.disk_name | |||
There was a problem hiding this comment.
It says @return [Boolean] but it actually returns true or nil... 🤔
Yard strictly defines Boolean as either true or false values, nothing else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying changes from new rubocop. Review per commit to distinguish what was done manually and what automatic.
see also yast/yast-yast2#1298