Fix bsc#1221049 #44
Merged
Fix bsc#1221049 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreidinger
reviewed
Mar 19, 2024
| previous_configs = SapHA::Helpers.get_configuration_files(@model.product_id) | ||
| previous_configs_popup(previous_configs) if !previous_configs.empty? | ||
| rescue StandardError => e | ||
| log.info "Could not parse previous config files: #{e.message}" |
There was a problem hiding this comment.
NP: I would probably use more specific exception and warning level. But nothing critical
jreidinger
approved these changes
Mar 19, 2024
|
✔️ Internal Jenkins job #66 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When configuration was saved befor installing last version the module can not be started.
The reason is that the class SapHA::Configuration::ClusterFinalizer was removed and implemented as a function of the class SapHA::Configuration::Hana
Solution
Catch error when the configuration file could not be parsed.