Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bsc#1221049 #41

Merged
merged 8 commits into from
Mar 19, 2024
Merged

Fix bsc#1221049 #41

merged 8 commits into from
Mar 19, 2024

Conversation

varkoly
Copy link
Collaborator

@varkoly varkoly commented Mar 19, 2024

Problem

When configuration was saved befor installing last version the module can not be started.
The reason is that the class SapHA::Configuration::ClusterFinalizer was removed and implemented as a function of the class SapHA::Configuration::Hana

Solution

Catch error when the configuration file could not be parsed.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 8338894627

Details

  • 0 of 7 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 29.357%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/sap_ha/configuration/hana.rb 0 1 0.0%
src/lib/sap_ha/wizard/scenario_selection_page.rb 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/lib/sap_ha/wizard/scenario_selection_page.rb 1 0.0%
Totals Coverage Status
Change from base Build 7887398382: -0.03%
Covered Lines: 1206
Relevant Lines: 4108

💛 - Coveralls

-------------------------------------------------------------------
Fri Mar 15 17:38:52 UTC 2024 - Peter Varkoly <varkoly@suse.com>

- yast2-sap-ha: Error occurred during the unattended installation: undefined class/module SapHA::Configuration::ClusterFinalizer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would split this line to two. I am not sure if it will be readable in rpm -q --changelog

@varkoly varkoly merged commit 4196e42 into yast:master Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants