Setup workflow is bad bsc#1217596

[varkoly]

The setup workflow of the cluster is bad.

The setup workflow of the cluster is bad. This does not exactly follow the order of the step described in the SUSE best practices

• Bugzilla link

Solution

The stup workflow was reworked:

1. Setting up SAP HANA System Replication
2. Setting up SAP HANA HA/DR providers
3. Confiugring the base cluster on all nodes
4. Configuring cluster properties and resources with the new function HANA.finalize

The whole class ClusterFinlizer was removed.

[coveralls]

Pull Request Test Coverage Report for Build 7882752593

Details

• -79 of 110 (28.18%) changed or added relevant lines in 9 files are covered.
• 5 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.2%) to 29.386%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/lib/sap_ha/sap_ha_installation.rb	0	1	0.0%
src/clients/sap_ha.rb	0	2	0.0%
src/lib/sap_ha/configuration.rb	0	2	0.0%
src/lib/sap_ha/configuration/cluster.rb	4	7	57.14%
src/lib/sap_ha/configuration/fencing.rb	4	7	57.14%
src/lib/sap_ha/wizard/hana_page.rb	0	4	0.0%
src/lib/sap_ha/wizard/base_wizard_page.rb	0	9	0.0%
src/lib/sap_ha/semantic_checks.rb	15	26	57.69%
src/lib/sap_ha/configuration/hana.rb	8	52	15.38%

Files with Coverage Reduction	New Missed Lines	%
src/lib/sap_ha/configuration/cluster.rb	1	62.99%
src/lib/sap_ha/configuration.rb	1	85.61%
src/lib/sap_ha/configuration/hana.rb	3	44.0%

Totals
Change from base Build 6931195097:	-0.2%
Covered Lines:	1206
Relevant Lines:	4104

---

💛 - Coveralls