Catch scc request timeout exception #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds proper timeout exception treatment on the method `RMT::WizardSCCPage#scc_credentials_valid?`: * Before: an "Internal error" message would be shown if a request timed out when contacting SCC to validate the credentials. * Now: a popup dialog will be shown, giving the user the choice to retry the request or cancel the operation. Additionally, the request has been enriched with a proper "user agent" to allow better debugging with SCC.
To enhance the 'User-Agent' used in the request headers, this commit adds the module constant `RMT::Version`, which must always match the package version specified in 'package/yast2-rmt.spec'. Additionally, a unit test was created to ensure the versions always match each other; if there is a version bump in packge spec file, the RSpec tests will break if 'src/lib/rmt.rb' is not updated accordingly.
Catch scc request timeout exception
…st-timeout-exception-master
lcaparroz
changed the title
Pull Request Test Coverage Report for Build 8359903887Details
💛 - Coveralls |
This commit updates the gem version of 'bundler' to match the one provided in Tumbleweed.
This commit removes the gem 'scc-codestyle' from the project, and adds 'rubocop-rspec' as a direct dependency to continue having the a similar set of linter rules. The 'scc-codestyle' version in use was too outdated, and updating it to a newer one would require a heavy restyling of the code.
After removing the gem 'scc-codestyle' (outdated version), Rubocop's default configuration caused a lot of warnings/errors when linting the project. This commit adds rules to 'rubocop.yml' so that the current code passes the linting process in the CI. Though I agree some of the rules are important to keep a good style for the project, the idea is just to adjust our CI process for Tumbleweed at the moment.
This commit bumps the Rubocop gem version to the latest one that is supported for ruby 2.5 (system version for SLES 15 SP6), according to the information available at: https://docs.rubocop.org/rubocop/compatibility.html
lcaparroz
force-pushed
the
catch-scc-request-timeout-exception-master
branch
from
38f1f42
to
84fc4b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sync changes from branch
SLE-15-SP6tomaster.Test
You can use the same instructions given on the Pull Request above, but using a container with a Tumbleweed image: