Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme fixes #519

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Theme fixes #519

wants to merge 5 commits into from

Conversation

jreidinger
Copy link
Member

@jreidinger jreidinger commented Nov 24, 2020

Draft of layout changes in registration dialog in installation. Several possible changes are shown. Basically each option represent evolution done by each commit.

Vertical Spacing Only

The first commit is just remove of vertical spacing:
qt:
reg_qt
ncurses:
reg_ncurses

Left Align

The second try to remove center align and instead align to left:
qt:
reg_qt_left

ncurses:
reg_ncurses_left

and minimal ncurses
reg_ncurses_left_min

Left Align and Margin Box

The third try includes left align and margin box around
reg_qt_left_margin
reg_ncurses_left_margin

Left Align and Horizontal Stretch

The forth try uses HStretch instead of Margin Box.
reg_qt_left_stretch
reg_ncurses_left_stretch
reg_qt_left_min_stretch

Left Align and Horizontal Stretch and Network Button separate

It is same as previous one, just network button is moved to right edge. Looks like there is agreement that this layout is the best one from proposed.
reg_qt_left_stretch_nb
reg_ncurses_left_stretch_nb
reg_ncurses_left_stretch_min_nb

@jreidinger
Copy link
Member Author

@kwwii Can you check screenshots here what you prefer? On the second set I can also try to define instead min size for input fields and remove it horizontal stretching, so it can be shorter in qt and also ncurses.

@coveralls
Copy link

coveralls commented Nov 24, 2020

Coverage Status

Coverage decreased (-0.3%) to 84.034% when pulling 6470464 on theme_fixes into 832dc62 on master.

@jreidinger
Copy link
Member Author

One more screenshot for default center aligned registration with high resolution which result in different view ( just part attached )

reg_qt_high_res

@mvidner
Copy link
Member

mvidner commented Dec 18, 2020

For testing of big-resolution layouts it may be helpful to scale down the qemu display so that it still fits your physical screen:

man qemu-kvm:

       During the graphical emulation, you can use special key combinations to
       change modes. The default key mappings are shown below, but if you use
       "-alt-grab" then the modifier is Ctrl-Alt-Shift (instead of Ctrl-Alt)
       and if you use "-ctrl-grab" then the modifier is the right Ctrl key
       (instead of Ctrl-Alt):

       Ctrl-Alt-f
           Toggle full screen

       Ctrl-Alt-+
           Enlarge the screen

       Ctrl-Alt--
           Shrink the screen

       Ctrl-Alt-u
           Restore the screen's un-scaled dimensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants