New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme fixes #519
Draft
jreidinger
wants to merge
5
commits into
master
Choose a base branch
from
theme_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Theme fixes #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kwwii Can you check screenshots here what you prefer? On the second set I can also try to define instead min size for input fields and remove it horizontal stretching, so it can be shorter in qt and also ncurses. |
jreidinger
force-pushed
the
theme_fixes
branch
from
December 16, 2020 10:36
fb51d33
to
e1f31cf
Compare
jreidinger
force-pushed
the
theme_fixes
branch
from
December 16, 2020 15:02
e1f31cf
to
31f4105
Compare
jreidinger
force-pushed
the
theme_fixes
branch
from
December 16, 2020 16:30
51be3e5
to
b92b2e2
Compare
jreidinger
force-pushed
the
theme_fixes
branch
from
December 16, 2020 16:36
b92b2e2
to
7765ba5
Compare
For testing of big-resolution layouts it may be helpful to scale down the qemu display so that it still fits your physical screen: man qemu-kvm:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of layout changes in registration dialog in installation. Several possible changes are shown. Basically each option represent evolution done by each commit.
Vertical Spacing Only
The first commit is just remove of vertical spacing:
qt:
ncurses:
Left Align
The second try to remove center align and instead align to left:
qt:
ncurses:
and minimal ncurses
Left Align and Margin Box
The third try includes left align and margin box around
Left Align and Horizontal Stretch
The forth try uses HStretch instead of Margin Box.
Left Align and Horizontal Stretch and Network Button separate
It is same as previous one, just network button is moved to right edge. Looks like there is agreement that this layout is the best one from proposed.