Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard secret attributes against leaking to the logs [master] #1366

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

shundhammer
Copy link
Contributor

Target Branch

This is the merge PR of #1365 to master.

Bugzilla

https://bugzilla.suse.com/show_bug.cgi?id=1221194

Trello

https://trello.com/c/6SAaaYZ3/

Problem

Secret attributes of the wifi connection object might leak to the logs, e.g. if methods like inspect() are used.

Solution

Mark them as secret with secret_attr from YaST2::SecretAttributes.

Test

  • Extended and executed the unit tests with packages from the same branch.

Related PRs

Copy link
Contributor

@teclator teclator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

coverage: 80.784% (+0.003%) from 80.781%
when pulling c974a08 on huha-pw-leak-master
into 2ac81c0 on master.

@shundhammer shundhammer merged commit 06af314 into master Mar 13, 2024
10 checks passed
@shundhammer shundhammer deleted the huha-pw-leak-master branch March 13, 2024 17:27
@yast-bot
Copy link
Contributor

❌ Internal Jenkins job #606 failed

@yast-bot
Copy link
Contributor

✔️ Internal Jenkins job #607 successfully finished
✔️ Created OBS submit request #1157994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants