Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust plymouth and First, Second stage start order. #1070

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qiangzhao
Copy link
Contributor

adjust Plymouth and Yast-First-Stage and Yast-Second-stage start order.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 40.786% when pulling 521dd6f on qiangzhao:coordinate-boot-sequence-plymouth-Yast2-Stage-service into 67e74d4 on yast:master.

Copy link
Member

@mvidner mvidner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! But WHY?

  • Please summarize the reason in a comment/commit message
  • Add a bug/feature reference

@qiangzhao
Copy link
Contributor Author

qiangzhao commented Dec 4, 2022

Please summarize the reason in a comment/commit message

plymouth-quit-wait is the solution inside plymouth source, the plymouth-quit-wait.service happens on the time plymouth totally exit. It is designed as a signal to notice other program which wait for using display device could launch.
From the old method, "Yast2-Firstboot.service" and "Yast2-Second-Stage.service" only call "plymoth quit", it will notice plymouth daemon to quit, but it will not wait for plymouth daemon to finish the quit action, in some scenarios, the release device action of plymouth daemon will take a little more time for kernel/DRM to return. In this case, if "Yast2-Firstboot.service" and "Yast2-Second-Stage.service" launch up, they may race with plymouth daemon to grasp the display device handle. and may lock each other.

Add a bug/feature reference

This is a problem that I found in my own research on Plymouth's source and systemd service files inside the Tumbleweed.

@qiangzhao
Copy link
Contributor Author

Hi @mvidner :
the reason as the above comment, Please review.

@dgdavid dgdavid requested a review from mvidner May 10, 2023 10:06
@kobliha
Copy link
Member

kobliha commented Dec 19, 2023

For the reference: https://bugzilla.suse.com/show_bug.cgi?id=1215282#c21 and the reason why @mvidner wanted some bug/feature nr is this https://bugzilla.suse.com/show_bug.cgi?id=1215282#c13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants