Fix Internal Error with docker 25.0.0 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 11, 2024 10:45
jreidinger
reviewed
Apr 17, 2024
src/lib/ydocker/changes_dialog.rb
Outdated
| @@ -1,3 +1,5 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
are you sure that it is safe to add it to files? I usually avoids this as it can lead to some nasty bugs.
There was a problem hiding this comment.
Ah, good point. I did think about that, then ran the module and clicked around and thought it was OK... so I included this.
But now I realize the test/ directory has only a useless spec helper 😱
So I will omit this and use the usual way in yast repos (which I did not realize before)
Style/FrozenStringLiteralComment:
Enabled: false
added 2 commits
April 17, 2024 11:36
because it can break working code and this package has actually no tests 😱
jreidinger
approved these changes
Apr 17, 2024
|
✔️ Internal Jenkins job #3 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Since Docker 25.0.0, starting
yast2 dockerjust pops up an Internal Error (unless you have no images at all)https://docs.docker.com/engine/api/v1.45/#tag/Image/operation/ImageList says for VirtualSize
Solution
So we need to fix yast2-docker to use
image.info["Size"]insteadTesting
Tested manually that the fix works with older Docker (on Leap 15.4 with 24.0.7)