Merge pull request #166 from yast/async-bug-ebadf

Don't close file descriptors in .target.bash calls (bsc#1218064)
yast · Jan 10, 2024 · 4ad226b · 4ad226b
2 parents f024117 + 631dd45
commit 4ad226b
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 4 deletions.
diff --git a/agent-system/src/ShellCommand.cc b/agent-system/src/ShellCommand.cc
@@ -145,9 +145,10 @@ shellcommand ( const string &target_root, const string &command, const string &t
 
 	    // #223602
 	    // close all file descriptors above stderr
-	    for ( int i = getdtablesize() - 1; i > 2; --i ) {
-		close( i );
-	    }
+            //
+            // But Ruby uses some for thread communications,
+            // bsc#1218064, so don't.
+            // Systemd daemon handling has meanwhile solved the original bug.
 
             // we want to work on different target root
             if (target_root != "/")

diff --git a/package/yast2-core.changes b/package/yast2-core.changes
@@ -1,3 +1,11 @@
+-------------------------------------------------------------------
+Wed Jan 10 16:22:03 UTC 2024 - Martin Vidner <mvidner@suse.com>
+
+- Don't close file descriptors in .target.bash calls (bsc#1218064)
+  avoiding "[ASYNC BUG] rb_thread_wakeup_timer_thread: write(3) EBADF"
+  with Ruby 3.3
+- 5.0.2
+
 -------------------------------------------------------------------
 Tue Nov 28 13:24:23 UTC 2023 - Stefan Hundhammer <shundhammer@suse.com>
 

diff --git a/package/yast2-core.spec b/package/yast2-core.spec
@@ -26,7 +26,7 @@
 %bcond_with werror
 
 Name:           yast2-core
-Version:        5.0.1
+Version:        5.0.2
 Release:        0
 Url:            https://github.com/yast/yast-core