Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Writing "root" entry into /etc/kernel/cmdline which is needed by sdbootutil #701

Merged
merged 7 commits into from May 3, 2024
Merged

Writing "root" entry into /etc/kernel/cmdline which is needed by sdbootutil #701

merged 7 commits into from May 3, 2024

Conversation

schubi2
Copy link
Member

@schubi2 schubi2 commented May 3, 2024 •
edited

  • sdbootutil needs the root entry in /etc/kernel/cmdline in order to write the correct bootloader menu entry.
  • /etc/kernel/cmdline has to be written before sdbootutil will be called.

Testing

  • Adapted test cases.
  • Tested manually in MicroOS(including transactional-update) and TW (while installation and in the installed system).

@coveralls
Copy link

Coverage Status

coverage: 87.371% (-0.04%) from 87.412%
when pulling 522e0f9 on sdbootutil
into d5388e6 on master.

joseivanlopez
joseivanlopez reviewed May 3, 2024
View reviewed changes
src/lib/bootloader/systemdboot.rb
@@ -227,7 +220,6 @@ def create_menue_entries
), command: e.commands.inspect, stderr: e.stderr)
)
end
File.delete(cmdline_file) if Yast::Stage.initial # see above
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has the file to be kept?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes :-)

@schubi2 schubi2 merged commit eda6950 into master May 3, 2024
12 checks passed
@schubi2 schubi2 deleted the sdbootutil branch May 3, 2024 16:45
@yast-bot
Copy link
Contributor

yast-bot commented May 3, 2024

✔️ Internal Jenkins job #118 successfully finished
✔️ Created OBS submit request #1171823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseivanlopez joseivanlopez joseivanlopez left review comments

@jreidinger jreidinger jreidinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@schubi2 @coveralls @yast-bot @jreidinger @joseivanlopez