Cache all entries to calculate index #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm... |
xwmx
added a commit
that referenced
this pull request
Oct 24, 2020
xwmx
added a commit
that referenced
this pull request
Oct 24, 2020
xwmx
added a commit
that referenced
this pull request
Oct 24, 2020
Shellcheck: SC2155 https://github.com/koalaman/shellcheck/wiki/SC2155 refs gh-57
xwmx
added a commit
that referenced
this pull request
Oct 25, 2020
refs gh-57 * master: Avoid unbound variable errors on macOS. Improve formatting in _list(). Improve spacing in `list`. Improve variable names in `list`. Improve alignment. Remove unneeded assignment in `count`. Count items scoped with options in `list`. Improve selection limit behavior in `list`. Update filename counting in `list` for streaming. Include additional test for `list` ids. Improve logic for displaying "omitted" in _list(). Stream data through _list()
xwmx
added a commit
that referenced
this pull request
Oct 25, 2020
refs gh-57 * master: Update version to 5.7.8 Improve variable name in _add().
delphinus
force-pushed
the
feature/cache-first
branch
from
f82affa
to
4cb6f5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure that this is a good way...
The current build reads
.indexand calculates the ID in showing each entry. This diff enables to cache all entries formerly and search them pretty fast.This effects most significantly, it improves 49s → 10s to
nb liston my box.nb listresult