Fix Python xbmc.getLanguage() return when UI language has regional variant #25062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be noted that the "region" returned by this function is the user UI setting "region default format", not necessarily the region associated with the language name. |
scott967
force-pushed
the
python_getLanguage
branch
from
bce834e
to
1a04481
Compare
fix 2 Update ModuleXbmc.cpp improve style Jenkins
scott967
force-pushed
the
python_getLanguage
branch
from
1a04481
to
8bb1208
Compare
|
Updated with Jenkins format |
|
From a quick review I think #23110 accomplishes this in a better design so am closing this to focus on that PR |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ModuleXbmc.cpp function getLanguage
The UI language was failing to return correct ISO 639-1 and ISO 639-2 language and optional region codes when UI language is set to a language with a regional variant -- for example, English (New Zealand). This fix splits the language English Name at " (" so only the language name is used when retrieving the language codes.
Motivation and context
Fix for #24990
How has this been tested?
Tested on Windows 10 x64 with OS locale en-us. Python addon created to call xbmc.getLanguage([format], [region]) for all 6 possible cases, including region=True and region=False.
What is the effect on users?
Addons using xbmc.getLanguage() will work properly.
Screenshots (if appropriate):
Types of change
Checklist: