Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dark-theme hack given upstream fix #94

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jthielen
Copy link
Collaborator

@jthielen jthielen commented Sep 9, 2022

Change Summary

Simply implements the changes suggested in #74! Did not test locally; hoping that CI will do the trick.

Related issue number

Closes #74.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable

@jthielen jthielen added the documentation Improvements or additions to documentation label Sep 9, 2022
@jthielen jthielen added this to the v0.0.2 milestone Sep 9, 2022
@jthielen
Copy link
Collaborator Author

jthielen commented Sep 9, 2022

This seems to fix the dark theme, but not auto (at least for me in Firefox 104 on Linux) for some reason?

Auto:

image

Light:

image

Dark:

image

I don't notice this issue with the existing hack. Does anyone else have this same issue?

@andersy005
Copy link
Member

I don't notice this issue with the existing hack. Does anyone else have this same issue?

i can confirm that i'm noticing the same issue (on MacOS, Safari)

@jthielen jthielen removed this from the v0.0.2 milestone Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dark-theme hack on next Xarray release
3 participants