Add cumsum #251
Draft
Add cumsum #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
dcherian
reviewed
Jul 7, 2023
tests/test_core.py
Outdated
| a = np.array([3, 4, 1, 3, 9, 9, 6, 7, 7, 0, 8, 2, 1, 8, 9, 8]) | ||
| b = npg.aggregate(group_idx, a, func="cumsum") | ||
|
|
||
| bb = groupby_reduce(a, group_idx, func="cumsum", engine="numpy")[0] |
There was a problem hiding this comment.
Let's add a groupby_accumulate(a, group_idx, func="sum", engine="numpy) that only returns a single array.
There was a problem hiding this comment.
I'm not a fan that groupby_reduce and groupby_accumulate wont have the same typing though.
There was a problem hiding this comment.
They are very different operations so they have to be. For e.g. method="map-reduce" isn't applicable. fill_value doesn't make any sense I don't think (an initial value does)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
dcherian
reviewed
Jul 10, 2023
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
dcherian
reviewed
Jul 10, 2023
Co-authored-by: Deepak Cherian <dcherian@users.noreply.github.com>
for more information, see https://pre-commit.ci
Illviljan
commented
Jul 10, 2023
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.