BluetoothLeGatt Sample #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: -Converted to JavaList and JavaDictionary to work with the ExpandableList -Use SetAdapter instead of Adapter property -Filter the already added devices OnLeScan using bluetooth address and not the object itself to avoid adding the same device more than once -Modified the method Lookup in SampleGattAttributes that was crashing the application Improvments: -When manually disconnecting from a device I am also closing the connection (trying to reuse the connection on some devices will take almost one minute to have the connection established again)
|
Thanks for submitting, we'll review shortly |
|
If this is going to be merged, my pull request has to be canceled, as it fixes the same errors but not all of them. #73 |
sebvinnac
suggested changes
Dec 19, 2019
There was a problem hiding this comment.
it can be nice if you add
if (Build.VERSION.SdkInt >= BuildVersionCodes.M) { RequestPermissions(new String[] { Android.Manifest.Permission.AccessCoarseLocation }, PERMISSION_REQUEST_COARSE_LOCATION); }
in the DeviceScanActivity.OnCreate
after the base.OnCreate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
-Converted to JavaList and JavaDictionary to work with the ExpandableList
-Use SetAdapter instead of Adapter property
-Filter the already added devices OnLeScan using bluetooth address and not the object itself to avoid adding the same device more than once
-Modified the method Lookup in SampleGattAttributes that was crashing the application
Improvments:
-When manually disconnecting from a device I am also closing the connection (trying to reuse the connection on some devices will take almost one minute to have the connection established again)