-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] TFM net8.0 #815
base: main
Are you sure you want to change the base?
Conversation
@@ -79,7 +79,7 @@ private void FabOnClick(object sender, EventArgs eventArgs) | |||
|
|||
public override void OnRequestPermissionsResult(int requestCode, string[] permissions, [GeneratedEnum] Android.Content.PM.Permission[] grantResults) | |||
{ | |||
Xamarin.Essentials.Platform.OnRequestPermissionsResult(requestCode, permissions, grantResults); | |||
Microsoft.Maui.ApplicationModel.Platform.OnRequestPermissionsResult(requestCode, permissions, grantResults); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, we have to pull in Maui essentials to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I "only" migrated Xamarin.Essentials code to MAUI Essentials.
Your samples do build, so I see no big issue. Even better we do test how everything works with MAUI side.
Does this change any of the generated binding API's?
Probably. Not sure yet. There were some Metadata changes.
Describe your contribution
In May support for Xamarin.Classic (
monoandroid12
) andnet6.0
will be dropped and this is recon PR to see what is ahead of the team.