TFM net8.0 and removal of net7.0 #804

moljac · 2023-10-24T16:13:25Z

net7.0-android hit EOL on May 14, 2024 and thus we will no longer support it in our AndroidX binding packages. Dropping net7.0-android will allow us to support packages that require API-34 like newer versions of Google Material going forward.

Update packages to use net8.0-android instead of net7.0-android.

Note that the "removed" published-namespaces are namespaces that only contained an empty Resources class that is no longer generated.

moljac · 2023-10-24T16:13:42Z

Round 01

Errors:

./generated/org.jetbrains.kotlin.kotlin-stdlib/obj/Release/net8.0-android/generated/src/Kotlin.Collections.Builders.AbstractMapBuilderEntrySet.cs(87,38): error CS0111: Type 'AbstractMapBuilderEntrySet' already defines a member called 'Contains' with the same parameter types [./generated/org.jetbrains.kotlin.kotlin-stdlib/org.jetbrains.kotlin.kotlin-stdlib.csproj::TargetFramework=net8.0-android]

./generated/org.jetbrains.kotlin.kotlin-stdlib/obj/Release/net8.0-android/generated/src/Kotlin.Collections.Builders.MapBuilder.cs(22,100): error CS0535: 'MapBuilder' does not implement interface member 'IMap.Size()' [./generated/org.jetbrains.kotlin.kotlin-stdlib/org.jetbrains.kotlin.kotlin-stdlib.csproj::TargetFramework=net8.0-android]
./generated/org.jetbrains.kotlin.kotlin-stdlib/obj/Release/net8.0-android/generated/src/Kotlin.Collections.Builders.MapBuilder.cs(22,100): error CS0535: 'MapBuilder' does not implement interface member 'IMap.Values()' [./generated/org.jetbrains.kotlin.kotlin-stdlib/org.jetbrains.kotlin.kotlin-stdlib.csproj::TargetFramework=net8.0-android]

./generated/org.jetbrains.kotlin.kotlin-stdlib/obj/Release/net8.0-android/generated/src/Kotlin.Collections.Builders.MapBuilderEntries.cs(22,30): error CS0534: 'MapBuilderEntries' does not implement inherited abstract member 'AbstractMutableSet.Add(Object?)' [./generated/org.jetbrains.kotlin.kotlin-stdlib/org.jetbrains.kotlin.kotlin-stdlib.csproj::TargetFramework=net8.0-android]
./generated/org.jetbrains.kotlin.kotlin-stdlib/obj/Release/net8.0-android/generated/src/Kotlin.Collections.Builders.MapBuilderEntries.cs(22,30): error CS0534: 'MapBuilderEntries' does not implement inherited abstract member 'AbstractMutableSet.GetSize()' [./generated/org.jetbrains.kotlin.kotlin-stdlib/org.jetbrains.kotlin.kotlin-stdlib.csproj::TargetFramework=net8.0-android]

moljac · 2023-10-24T18:17:28Z

Round 02

Errors:

./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Prf.AesCmacPrfKey.cs(122,73): error CS0115: 'AesCmacPrfKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Prf.HkdfPrfKey.cs(192,73): error CS0115: 'HkdfPrfKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Prf.HmacPrfKey.cs(192,73): error CS0115: 'HmacPrfKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.StreamingAead.AesCtrHmacStreamingKey.cs(109,73): error CS0115: 'AesCtrHmacStreamingKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.StreamingAead.AesGcmHkdfStreamingKey.cs(109,73): error CS0115: 'AesGcmHkdfStreamingKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Signature.EcdsaPrivateKey.cs(231,66): error CS0115: 'EcdsaPrivateKey.GetPublicKey()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Signature.EcdsaPublicKey.cs(290,73): error CS0115: 'EcdsaPublicKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Signature.Ed25519PrivateKey.cs(122,66): error CS0115: 'Ed25519PrivateKey.GetPublicKey()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Signature.Ed25519PublicKey.cs(152,73): error CS0115: 'Ed25519PublicKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Signature.RsaSsaPkcs1PrivateKey.cs(414,66): error CS0115: 'RsaSsaPkcs1PrivateKey.GetPublicKey()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Signature.RsaSsaPssPrivateKey.cs(401,66): error CS0115: 'RsaSsaPssPrivateKey.GetPublicKey()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Signature.RsaSsaPkcs1PublicKey.cs(290,73): error CS0115: 'RsaSsaPkcs1PublicKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]
./generated/com.google.crypto.tink.tink-android/obj/Debug/net8.0-android/generated/src/Xamarin.Google.Crypto.Tink.Signature.RsaSsaPssPublicKey.cs(290,73): error CS0115: 'RsaSsaPssPublicKey.GetParameters()': no suitable method found to override [./generated/com.google.crypto.tink.tink-android/com.google.crypto.tink.tink-android.csproj::TargetFramework=net8.0-android]

moljac · 2023-10-31T09:54:33Z

https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=8618748&view=logs&j=3b059b26-55fe-5273-567a-5b3fa6c051e7&t=90a64c1c-0058-5f10-5c08-27329dc26712

CI builds 280 errors like:

2023-10-31T08:50:36.7536580Z /Users/runner/hostedtoolcache/dotnet/sdk/8.0.100-rc.2.23502.2/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(398,5): error NETSDK1073: The FrameworkReference 'Microsoft.Android' was not recognized [/Users/runner/work/1/s/generated/io.reactivex.rxjava3.rxkotlin/io.reactivex.rxjava3.rxkotlin.csproj::TargetFramework=net8.0-android]

moljac · 2023-11-01T07:51:02Z

/azp run

azure-pipelines · 2023-11-01T07:51:14Z

Azure Pipelines successfully started running 1 pipeline(s).

moljac · 2023-11-04T21:58:02Z

/azp run

azure-pipelines · 2023-11-04T21:58:13Z

Azure Pipelines successfully started running 1 pipeline(s).

MagicAndre1981 · 2024-06-03T19:00:12Z

I have no why you requested review from me, but it is green and .net 7.0 is now dead, go and merge it.

moljac · 2024-06-03T21:47:14Z

I have no why you requested review from me, but it is green and .net 7.0 is now dead, go and merge it.

You were in reviewers list (most likely because you commented). net7.0 is not completely dead, because there was update last week, but yes we need to switch to net8.0, because of some other issues.

net8.0 is on its way. this week i hope

…droidX into mu-20231024-tfm-net80

TFM net8.0

a663bd4

moljac added do-not-merge PR is still in progress and is not ready to be merged investigating in-progress in progress in-test labels Oct 24, 2023

moljac self-assigned this Oct 24, 2023

moljac added 2 commits October 24, 2023 18:23

CI dotnet 8.0

cdf36ca

kotlin-stdlib metadata fixes

ca039ce

moljac added 8 commits October 24, 2023 22:47

crypto-tink metadata fixes

9e1fdb2

Corrected folders fro new TFM

2fd2093

samples (TFM net8.0-android and removal of classic samples)

c0053ca

samples fixes

3a7739b

android workload added (errors in build step for samples)

aa499f8

TFM fixed

e406a8b

Update published-namespaces.txt

532f50a

Merge branch 'main' into mu-20231024-tfm-net80

338d7d3

moljac marked this pull request as draft November 1, 2023 06:57

moljac added 6 commits November 6, 2023 16:42

Merge branch 'main' into mu-20231024-tfm-net80

2a1c0e1

Update workloads.json with 8.0.100 band

8484e21

Update workloads.json mono and emscripten

6b4f1a8

Update workloads.json rc2 added

481e13d

Update workloads.json

313e0d2

Update build.yml dotnetWorkloadSource

e8dcb33

moljac added 6 commits May 2, 2024 08:28

Merge branch 'main' into mu-20231024-tfm-net80

0b93bb9

Merge branch 'main' into mu-20231024-tfm-net80

e02bbfd

automatic files

9cb8b6b

Merge branch 'main' into mu-20231024-tfm-net80

08b1a19

Merge branch 'main' into mu-20231024-tfm-net80

4bac59c

Update published-namespaces.txt

434e1ba

moljac changed the title ~~[DO NOT MERGE] TFM net8.0~~ TFM net8.0 and removal of net7.0 Jun 3, 2024

moljac removed the do-not-merge PR is still in progress and is not ready to be merged label Jun 3, 2024

moljac marked this pull request as ready for review June 3, 2024 14:37

moljac requested review from jpobst and MagicAndre1981 June 3, 2024 14:37

moljac added 4 commits June 3, 2024 16:40

8.0.301 bumps

eb47cf5

workloads bumped to latest

3f66abd

build.cake fixes for nuget CPM

11d2425

improved anc cleaned up nuget CPM

5f76c39

moljac and others added 2 commits June 3, 2024 21:05

Merge branch 'main' into mu-20231024-tfm-net80

66b6fd4

Clean up obsolete metadata.

1d8b6b9

jpobst force-pushed the mu-20231024-tfm-net80 branch from 2a7f03d to 1d8b6b9 Compare June 3, 2024 19:32

moljac removed in-progress in progress in-test labels Jun 3, 2024

moljac added 3 commits June 4, 2024 07:28

automatic files

d9b1059

Merge branch 'mu-20231024-tfm-net80' of https://github.com/xamarin/An…

a4b0528

…droidX into mu-20231024-tfm-net80

Merge branch 'main' into mu-20231024-tfm-net80

6885c6d

jpobst approved these changes Jun 4, 2024

View reviewed changes

jpobst mentioned this pull request Jun 4, 2024

Update to net8.0-android. #898

Closed

MagicAndre1981 approved these changes Jun 4, 2024

View reviewed changes

moljac merged commit c646c3d into main Jun 11, 2024
5 checks passed

moljac deleted the mu-20231024-tfm-net80 branch June 11, 2024 16:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TFM net8.0 and removal of net7.0 #804

TFM net8.0 and removal of net7.0 #804

moljac commented Oct 24, 2023 •

edited by jpobst

moljac commented Oct 24, 2023 •

edited

moljac commented Oct 24, 2023

moljac commented Oct 31, 2023

moljac commented Nov 1, 2023

azure-pipelines bot commented Nov 1, 2023

moljac commented Nov 4, 2023

azure-pipelines bot commented Nov 4, 2023

MagicAndre1981 commented Jun 3, 2024

moljac commented Jun 3, 2024

TFM net8.0 and removal of net7.0 #804

TFM net8.0 and removal of net7.0 #804

Conversation

moljac commented Oct 24, 2023 • edited by jpobst

moljac commented Oct 24, 2023 • edited

moljac commented Oct 24, 2023

moljac commented Oct 31, 2023

moljac commented Nov 1, 2023

azure-pipelines bot commented Nov 1, 2023

moljac commented Nov 4, 2023

azure-pipelines bot commented Nov 4, 2023

MagicAndre1981 commented Jun 3, 2024

moljac commented Jun 3, 2024

moljac commented Oct 24, 2023 •

edited by jpobst

moljac commented Oct 24, 2023 •

edited