Background Cube #1098
Open
Background Cube #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Background Cube images look different between x3dom 1.7.2 (good) and 1.8.1 (ugly). The reason was not as initially suspected, the size of the generated background sphere - this size is in fact irrelevant- but because the wrong shader name BACKGROUND_CUBETEXTURE_DDS which is used even if you do not provide an dds file. After replacing the shader name, the images look as expected and all images are connected correctly to fill the cube. However, there is still one more difference: the view is flipped upside down. So far I tested only using http://github/x3d-solar-system with the original images and another background picture set.
|
see also #973 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background Cube images look different between x3dom 1.7.2 (good) and 1.8.1 (ugly). The reason was not, as initially suspected, the size of the generated background sphere - this size is in fact irrelevant- but because the wrong shader name
BACKGROUND_CUBETEXTURE_DDSwhich is used even if you do not provide an dds file.After replacing the shader name, the images look as expected and all images are connected correctly to fill the cube.
However, there is still one more difference: the view is flipped upside down.
So far I tested only using https://github.com/fblupi/x3d-solar-system with the original images and another background picture set.
The current commit contains some additional comments which I woul remove later.
Maybe it's not so easy. Here are some samples from the history:
(How to create a complete history for a spiecific piece of code? - I only know how to poke manually in the blame list.)
dds support for the background-node, some ibl fixes, gltf2 example up… 13.06.2018
50d83ab
Indroduction of BACKGROUND_CUBETEXTURE_DDS, keeping BACKGROUND_CUBETEXTURE in the other case.
use dds order for background 04.08.2019
9529b88
BACKGROUND_CUBETEXTURE_DDS is used for normal images, too
Contains comment: "Since the dds background shader is used also for the case of six individual background face textures, we also need to the dds order for creating the texture cube."
Merge branch 'master' of https://github.com/x3dom/x3dom into webVR 30.08.2018
dde7320
BACKGROUND_CUBETEXTURE is used for normal images