Fixes for wxDateTime and generic wxDatePickerCtrl date parsing
#24541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some locales use format specifiers not supported (yet) by wxDateTime::Parse() and while the best fix is to add support for them, as it has been already done for %F (see wxWidgets#24173) and will be done for "%-" (see wxWidgets#24533) soon, it still seems wise to handle the locales for which it still might happen, now or in the future, more gracefully by falling back to ISO 8601 date format if the locale format can't be used because we can't parse it. Note that an alternative approach could consist in using the locale format for formatting the dates and falling back to ISO 8601 only for parsing them, but it would arguably be confusing to the user if the program expected input in a format different from what it uses for displaying the dates, so prefer just using the same format for both, if we can't do otherwise.
Remove completely unnecessary DateTimeTestCase and use CHECK() instead of CppUnit macros.
It wasn't very logical to have them in the same test case as the tests for wxDateTime::Format(). No real changes.
This allows to use REQUIRE() for the tests which must not fail for the subsequent tests in the same section to succeed.
This isn't the case any more since a long time, see 89a7e1f (Added wxLOCALE_DATE/TIME_FMT support to wxLocale::GetInfo()., 2009-03-29).
This is not really used when parsing, but we still need to support the GNU extensions to the strftime() formatting specifiers used to change padding, as they can (and do, at least in the case of "%-d" and "%-m") occur in the locale descriptions and so can be used when parsing dates using the current locale format. Closes wxWidgets#24533.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #24533 and does some small extra cleanup.
Note that this doesn't add support for
%E*and%O*as this is much more involved, as described there.