Check wxXRC_NO_RELOADING out of the loop #24536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small optimisation: Instead of checking if the wxXRC_NO_RELOADING flag is set, inside the loop that checks each XmlResource record, this will check the flag before the loop itself is even started.
|
Is there someone who can restart the failed check? For some reason something went wrong and the check timed-out. I do expect that restarting the check will let it pass (as the other checks did). Thanks in advance! |
|
Thanks, I'll apply this soon although I'd like to just |
|
@vadz I already updated the files for you, so it now directly returns from wxXmlResource::UpdateResources if wxXRC_NO_RELOADING is set. |
|
Thanks for the update! Will (squash) merge soon. |
vadz
pushed a commit
to vadz/wxWidgets
that referenced
this pull request
May 19, 2024
Check wxXRC_NO_RELOADING out of the loop to avoid looping over all XRC files. See wxWidgets#24536. (cherry picked from commit ef0e3f8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimisation:
Instead of checking if the wxXRC_NO_RELOADING flag is set, inside the loop that checks each XmlResource record, this will check the flag before the loop itself is even started.