Code readability improvements #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract large result warning logic to dedicated methods so that the controller action is not so long.
1) the name is misleading, as of a recent refactoring the generation activity is "lazy", meaning the report generation is not triggered until it's being accessed. This allows to instantiate and object and do other opeations on it. 2) The abstraction is not used and just makes the code harder to reason about. If a different report type is needed, an abstraction can be added knowing all the context about it, not prematurely...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at this code for debugging reasons and made a few improvements to make the code easier to understand. No changes in behaviour. See each commit not for rationale.