Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Clean up dist #3133

Merged
merged 2 commits into from
May 20, 2024
Merged

build: Clean up dist #3133

merged 2 commits into from
May 20, 2024

Conversation

josephfusco
Copy link
Member

What does this implement/fix? Explain your changes.

Updates the .distignore to prevent unnecessary files from being included in the build.

Does this close any currently open issues?

Fixes #3126

@justlevine
Copy link
Collaborator

Do we also need to update .gitattributes? Do we even use .gitattributes?

@josephfusco
Copy link
Member Author

@justlevine good call!

Given that .gitattributes is only being used for export-ignore, it seems the only benefit would be for when a zip is downloaded from GitHub.

download zip

If vendor dependencies aren't available in this zip, it doesn't feel like it's adding any value right now.

… distributed on WordPress.org.

Users downloading a .zip of the plugin from Github should get everything downloaded as it is considered a development artifact and not a production artifact.
Copy link

codeclimate bot commented May 17, 2024

Code Climate has analyzed commit 398a3aa and detected 0 issues on this pull request.

View more on Code Climate.

@jasonbahl jasonbahl merged commit 5d3cd82 into develop May 20, 2024
8 checks passed
@renatonascalves renatonascalves deleted the fix/3126-clean-up-dist branch May 20, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove development-related files from SVN on release
3 participants