-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeyModes #167
base: master
Are you sure you want to change the base?
KeyModes #167
Conversation
includes updated KeyBindManager & Bar Widget
Hi @rickbutton , is this something you'd want to include and does the overall implementation approach work for you? There's still a few things that would require fixing but I'd be a tad more motivated to get around to that if I knew that this is something that ultimately could get merged. LMK what you think! |
This reverts commit 873ea11.
Though I don't think I would use this, I think this is an interesting and valuable idea. |
With regard to compatibility, does this change break existing usage of the existing |
Also: This PR now have merge conflicts against git master. Those will have to be fixed before we can merge 🙂 |
@N1x0 : if you want to follow up on this PR, I’m sure it will get merged faster this time around. Just fix up the merge-conflict and we should be good to go 🤠 |
Will have a look at the conflicts and try to get it implemented without breaking existing configs |
Offer still stands. Fix up the conflicts and we can try to get this merged 😄 |
This PR adds different user-configurable modes for key & mouse binds.
The user can create different mode objects and Subscribe
Keybinds
on these.Modes are activated using
context.Keybinds.SetMode(KeyMode mode)
KeyMode
takes the following parametername
is used for the label of the accompanyingKeyModeWidget
,defaultsEnabled
subscribes to the default Keybinds. isfalse
by defaultHere an example configuration
KeybindDialog
to reflect the bindings of the current modeKeyModeWidget screenshots
Work KeyMode
Game KeyMode