Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-App Updates: Update blocking modal UI #23220

Merged
merged 2 commits into from
May 22, 2024
Merged

In-App Updates: Update blocking modal UI #23220

merged 2 commits into from
May 22, 2024

Conversation

momo-ozawa
Copy link
Contributor

Part of https://github.com/Automattic/wordpress-mobile/issues/55
Part of https://github.com/Automattic/wordpress-mobile/issues/56

Description

Ref: p1715867986819249-slack-C072JBZL84U

  • Updates the blocking modal "Update" button title to "Get the latest version"
  • Removes the "More info" button
Before After

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@momo-ozawa momo-ozawa added this to the 25.0 milestone May 16, 2024
@momo-ozawa momo-ozawa requested a review from kean May 16, 2024 18:57
@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 16, 2024 •
edited

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23220-4612cd3
Version24.9
Bundle IDorg.wordpress.alpha
Commit4612cd3
App Center BuildWPiOS - One-Offs #9933
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 16, 2024 •
edited

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23220-4612cd3
Version24.9
Bundle IDcom.jetpack.alpha
Commit4612cd3
App Center Buildjetpack-installable-builds #8983
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@momo-ozawa momo-ozawa force-pushed the task/iau-update-button-copy branch from 096c3a1 to 4612cd3 Compare May 17, 2024 10:01
Base automatically changed from task/iau-phased-release to trunk May 22, 2024 08:10
@momo-ozawa momo-ozawa merged commit 8e1233e into trunk May 22, 2024
24 checks passed
@momo-ozawa momo-ozawa deleted the task/iau-update-button-copy branch May 22, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kean kean kean approved these changes

Assignees
No one assigned
Labels
In-App Updates [Type] Task
Projects
None yet
Milestone
25.0 ❄️
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@momo-ozawa @wpmobilebot @kean