VtoC: Prototype #23205
VtoC: Prototype #23205
Conversation
Generated by 🚫 Danger |
kean
force-pushed
the
task/integrate-jetpack-ai
branch
2 times, most recently
from
9094ff8
to
4e7cf01
Compare
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23205-50c0995 | |
| Version | 24.9 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 50c0995 | |
| App Center Build | WPiOS - One-Offs #9975 |
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23205-50c0995 | |
| Version | 24.9 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 50c0995 | |
| App Center Build | jetpack-installable-builds #9025 |
There was a problem hiding this comment.
I understand that this is a prototype / a foundation to build on, so I haven't done a thorough test. The happy path seems to work well, but I noticed that if you record without saying anything, then tap "Done", the flow generates a paragraph block with the text "Thank you."
| host.modalPresentationStyle = .formSheet | ||
| } else { | ||
| if let sheetController = host.sheetPresentationController { | ||
| sheetController.detents = [.medium()] |
There was a problem hiding this comment.
On smaller devices, "Post from audio" is obscured in the sheet
| iPhone SE (17.4.1) | iPhone 15 Pro (17.0) |
|---|---|
 |
 |
There was a problem hiding this comment.
I suggest addressing it when we start working on the final design.
| @@ -24,8 +24,7 @@ import WordPressUI | |||
| private let noticeAnimator = NoticeAnimator(duration: 0.5, springDampening: 0.7, springVelocity: 0.0) | |||
|
|
|||
| private func notice(for blog: Blog) -> Notice { | |||
| let showsStories = blog.supports(.stories) | |||
| let title = showsStories ? NSLocalizedString("Create a post, page, or story", comment: "The tooltip title for the Floating Create Button") : NSLocalizedString("Creates new post, or page", comment: " Accessibility hint for create floating action button") | |||
| let title = NSLocalizedString("Creates new post, or page", comment: " Accessibility hint for create floating action button") | |||
There was a problem hiding this comment.
I wonder if we should use the same copy as showCreateButton - "Create a post or page"
There was a problem hiding this comment.
Good point – I moved this to Stings too.
| wpAssertionFailure("blog missing") | ||
| return | ||
| } | ||
| let viewModel = VoiceToContentViewModel(blog: blog) { [ weak self] transcription in |
There was a problem hiding this comment.
[nit]
| let viewModel = VoiceToContentViewModel(blog: blog) { [ weak self] transcription in | |
| let viewModel = VoiceToContentViewModel(blog: blog) { [weak self] transcription in |
| Text("File size limit: 25 MB") | ||
| Text("Recording time limit: 5 minutes") |
There was a problem hiding this comment.
Are these hardcoded values?
There was a problem hiding this comment.
Yeah, I added a todo in the latest PR.
| var body: some View { | ||
| VStack(spacing: 34) { | ||
| VStack(spacing: 16) { | ||
| Text("Post from Audio") |
There was a problem hiding this comment.
Can you make the strings in this file localizable strings? Thanks!
There was a problem hiding this comment.
On second thought, I can do this when I implement the updated design
huh, good catch. I wonder if we can even do anything about it. |
kean
force-pushed
the
task/integrate-jetpack-ai
branch
from
4e7cf01
to
50c0995
Compare
Part of https://github.com/Automattic/wordpress-mobile/issues/102
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: