Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrepreneur Signup: Simplify final step in CYS when entering from Entrepreneur signup flow. #47578

Merged
merged 5 commits into from
May 21, 2024

Conversation

yansern
Copy link
Contributor

@yansern yansern commented May 17, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Simplify final step in CYS when entering from Entrepreneur signup flow.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Sync to your WoA site on Entrepreneur plan.
  2. Go through the Design With AI flow until you reach the Site Assembler flow and reach the final stepyour_site_here.wpcomstaging.com/wp-admin/admin.php?page=wc-admin&path=%2Fcustomize-store%2Fdesign-with-ai&ref=entrepreneur-signup.
  3. You should see the simplified view of the final step.
  4. All of the buttons should work.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

2024-05-17_20-31-22

@yansern yansern self-assigned this May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@yansern yansern changed the title Entrepreneur Signup: Simplify final step in CYS when entering from Entrepreneur Signup. Entrepreneur Signup: Simplify final step in CYS when entering from Entrepreneur signup flow. May 17, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label May 17, 2024
@yansern yansern added the focus: customize-your-store Issues related to the Customize Your Store onboarding flow. label May 17, 2024
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes look good. Nice! 👍🏼 There are two regressions though - but easy to fix (please see the inline comments). 🙂

@yansern
Copy link
Contributor Author

yansern commented May 20, 2024

Okay fixed and double checked for regressions. No regressions. All should be good now.

Entrepreneur Signup
2024-05-20_17-37-06

Regular version
2024-05-20_17-37-43

@yansern yansern force-pushed the update/entrepreneur-signup-simplify-cys-final-step branch from baf746b to f49240d Compare May 20, 2024 09:54
Copy link
Contributor

@ivan-ottinger ivan-ottinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The changes look good and work as exppected! Perfect! One tiny thing I noticed - related to translations.

Comment on lines +95 to +98
? __(
"Congratuations! You've successfully designed your store. Now you can go back to the Home screen to complete your store setup and start selling.",
'woocommerce'
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the translations, they don't exist for this new string yet. I think we could consider using the existing one until the new one is ready.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine because Woo 9.0 will only be shipped 3-4 weeks from now. Just need to make it to the code freeze first.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine because Woo 9.0 will only be shipped 3-4 weeks from now. Just need to make it to the code freeze first.

Oh, I see. Makes sense! With knowing that, I think the PR is good to go. 🚀

@yansern yansern force-pushed the update/entrepreneur-signup-simplify-cys-final-step branch from a513d08 to d461aae Compare May 21, 2024 13:14
@yansern
Copy link
Contributor Author

yansern commented May 21, 2024

The Tracks event is now in, and this PR is rebased. Just awaiting tests to complete.
image

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@gigitux gigitux enabled auto-merge (squash) May 21, 2024 13:54
@gigitux gigitux merged commit 9a1f987 into trunk May 21, 2024
24 checks passed
@gigitux gigitux deleted the update/entrepreneur-signup-simplify-cys-final-step branch May 21, 2024 13:56
@github-actions github-actions bot added this to the 9.0.0 milestone May 21, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 21, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants