-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Entrepreneur Signup: Show WordPress logo when entering Design With AI from Entrepreneur signup flow. #47576
Entrepreneur Signup: Show WordPress logo when entering Design With AI from Entrepreneur signup flow. #47576
Conversation
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Hi @gigitux, Apart from reviewing the code changes, please make sure to review the testing instructions as well. You can follow this guide to find out what good testing instructions should look like: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great.
6988752
to
0e74009
Compare
I've retested DesignWithAI & SiteAssembler after rebase. All good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise the PR LGTM! I don't consider it a blocker but it would be great if we could avoid to use !important
: if time allows, could you take a look before merging it?
width: 24px !important; | ||
height: 24px !important; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we avoid to use !important
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay interesting. After the rebase, I didn't need to use !important
anymore.
Submission Review Guidelines:
Changes proposed in this Pull Request:
Show WordPress logo when entering Design With AI from Enterpreneur signup flow.
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
your_site_here.wpcomstaging.com/wp-admin/admin.php?page=wc-admin&path=%2Fcustomize-store%2Fdesign-with-ai&ref=entrepreneur-signup
.Changelog entry
Significance
Type
Message
Comment