Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entrepreneur Signup: Show WordPress logo when entering Design With AI from Entrepreneur signup flow. #47576

Merged

Conversation

yansern
Copy link
Contributor

@yansern yansern commented May 17, 2024

Submission Review Guidelines:

Changes proposed in this Pull Request:

Show WordPress logo when entering Design With AI from Enterpreneur signup flow.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Sync to your WoA site on Entrepreneur plan.
  2. Go to Design With AI your_site_here.wpcomstaging.com/wp-admin/admin.php?page=wc-admin&path=%2Fcustomize-store%2Fdesign-with-ai&ref=entrepreneur-signup.
  3. You should see a black & white WordPress logo on Design With AI flow.
  4. You should see the Blue logo now replaced with black & white WordPress logo on Site Assembler flow.
  5. Ignore the mispositioning of Site Title, that is addressed in Entrepreneur Signup: Hide site title when entering from Entrepreneur signup flow. #47581.

Changelog entry

  • Automatically create a changelog entry from the details below.

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Comment

2024-05-17_19-59-10 2024-05-17_19-59-18 2024-05-17_19-58-08 2024-05-17_21-13-34 2024-05-17_21-18-19

@yansern yansern self-assigned this May 17, 2024
Copy link
Contributor

github-actions bot commented May 17, 2024

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@yansern yansern changed the title Entrepreneur SIgnup: Show WordPress logo when entering Design With AI from Enterpreneur signup flow. Entrepreneur Signup: Show WordPress logo when entering Design With AI from Enterpreneur signup flow. May 17, 2024
@yansern yansern added focus: customize-your-store Issues related to the Customize Your Store onboarding flow. plugin: woocommerce Issues related to the WooCommerce Core plugin. labels May 17, 2024
@yansern yansern requested a review from gigitux May 20, 2024 09:19
Copy link
Contributor

Hi @gigitux,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

Copy link

@JuanLucha JuanLucha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

@yansern yansern force-pushed the update/entrepreneur-signup-show-wp-logo-on-design-with-ai branch from 6988752 to 0e74009 Compare May 20, 2024 11:08
@yansern yansern changed the title Entrepreneur Signup: Show WordPress logo when entering Design With AI from Enterpreneur signup flow. Entrepreneur Signup: Show WordPress logo when entering Design With AI from Entrepreneur signup flow. May 20, 2024
@yansern
Copy link
Contributor Author

yansern commented May 20, 2024

I've retested DesignWithAI & SiteAssembler after rebase. All good.

Copy link
Contributor

@gigitux gigitux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise the PR LGTM! I don't consider it a blocker but it would be great if we could avoid to use !important: if time allows, could you take a look before merging it?

Comment on lines 322 to 324
width: 24px !important;
height: 24px !important;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we avoid to use !important?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay interesting. After the rebase, I didn't need to use !important anymore.

@gigitux gigitux merged commit 645b052 into trunk May 20, 2024
25 checks passed
@gigitux gigitux deleted the update/entrepreneur-signup-show-wp-logo-on-design-with-ai branch May 20, 2024 13:43
@github-actions github-actions bot added this to the 9.0.0 milestone May 20, 2024
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label May 20, 2024
@rodelgc rodelgc added needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
focus: customize-your-store Issues related to the Customize Your Store onboarding flow. needs: external testing Indicates if the PR requires further testing conducted by testers external to the development team. plugin: woocommerce Issues related to the WooCommerce Core plugin. status: analysis complete Indicates if a PR has been analysed by Solaris
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants