[CYS] Patterns Migration: Performance - ensure the initial request to fetch patterns from the PTK is async

[albarin]

Submission Review Guidelines:

• I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have reviewed my code for security best practices.
• Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

This PR ensures requests to the PTK API are done async when:

• The woocommerce_allow_tracking option changes to enabled.
• The WooCommerce plugin is activated (if woocommerce_allow_tracking is enabled).
• The WooCommerce plugin is updated.

Also ensures that the PTK patterns cache is flushed when:

• The WooCommerce plugin is deactivated.
• The woocommerce_allow_tracking option is disabled.

Closes #47403

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Pre-requisites

• Go to wp-admin/tools.php?page=woocommerce-admin-test-helper, go to Features, and enable the pattern-toolkit-full-composability.
• Install the Transients Manager plugin (this is just for convenience since it provides an easy way of removing transients from the database).

When the woocommerce_allow_tracking option changes to enabled, PTK patterns are fetched

1. Go to wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com and make sure Allow usage of WooCommerce to be tracked is unchecked.
2. On the same page, check the option from the previous step and Save.
3. Go to wp-admin/tools.php?page=action-scheduler, search for the fetch_patterns action, and make sure it was scheduled.
4. Click on Run under the action name if it is still pending and wait until is completed.
5. Go to wp-admin/tools.php?s=ptk_patterns&page=transients-manager and make sure the ptk_patterns transient is set.
6. Create a new page or post and make sure you can insert the Intro: Left-aligned header and button pattern.

When the WooCommerce plugin is activated (if woocommerce_allow_tracking is enabled), PTK patterns are fetched

1. Go to wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com and make sure Allow usage of WooCommerce to be tracked is checked.
2. Deactivate the WooCommerce plugin.
3. Go to wp-admin/tools.php?s=ptk_patterns&page=transients-manager and delete the ptk_patterns transient if present.
4. Activate it again.
5. Go to wp-admin/tools.php?page=action-scheduler, search for the fetch_patterns action, and make sure it was scheduled.
6. Click on Run under the action name if it is still pending and wait until is completed.
7. Create a new page or post and make sure you can insert the Intro: Left-aligned header and button pattern.

When the WooCommerce plugin is updated, PTK patterns are fetched

1. Install WooCommerce from this ZIP file.
2. Go to wp-admin/tools.php?s=ptk_patterns&page=transients-manager and delete the ptk_patterns transient.
3. Go to Plugins and click on update to update the WooCommerce plugin.
4. Go to wp-admin/tools.php?page=action-scheduler, search for the fetch_patterns action, and make sure it was scheduled (don't worry if it fails, it should at this point).

When the WooCommerce plugin is deactivated, PTK patterns are flushed

1. Go to wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com and make sure Allow usage of WooCommerce to be tracked is checked.
2. Go to wp-admin/tools.php?s=ptk_patterns&page=transients-manager and make sure the ptk_patterns transient is set.
3. Go to Plugins and disable WooCommerce.
4. Go to wp-admin/tools.php?s=ptk_patterns&page=transients-manager and make sure the ptk_patterns transient is not present.
5. Create a new page or post and make sure you cannot insert the Intro: Left-aligned header and button pattern.

When the woocommerce_allow_tracking option is disabled, PTK patterns are flushed

1. Go to wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com and make sure Allow usage of WooCommerce to be tracked is checked.
2. Go to wp-admin/tools.php?s=ptk_patterns&page=transients-manager and make sure the ptk_patterns transient is set.
3. Go to wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com, uncheck Allow usage of WooCommerce to be tracked, and save.
4. Go to wp-admin/tools.php?s=ptk_patterns&page=transients-manager and make sure the ptk_patterns transient is not present.
5. Create a new page or post and make sure you cannot insert the Intro: Left-aligned header and button pattern.

Changelog entry

• Automatically create a changelog entry from the details below.

Significance

• Patch
• Minor
• Major

Type

• Fix - Fixes an existing bug
• Add - Adds functionality
• Update - Update existing functionality
• Dev - Development related task
• Tweak - A minor adjustment to the codebase
• Performance - Address performance issues
• Enhancement - Improvement to existing functionality

Message

[CYS] Ensure fetch PTK patterns requests are always done async to improve performance.

Comment

[github-actions]

Hi @gigitux, @nefeline, @kmanijak,

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

[nefeline]

Excellent work, @albarin !

I just noticed some mixups in the testing instructions:

When the woocommerce_allow_tracking option changes to enabled, PTK patterns are fetched

Go to wp-admin/admin.php?page=wc-settings&tab=advanced&section=woocommerce_com and make sure Allow usage of WooCommerce to be tracked is unchecked.

In this case you meant "checked", right?

When the WooCommerce plugin is updated, PTK patterns are fetched

Install WooCommerce from this ZIP file.

The link to zip file is missing :)

Apart from that, everything else is testing great and working as expected!

[gigitux]

Great work! Great job on adding unit tests 🚀

I'm pre-approving the PR, but I left a minor comment! Let me know what you think about it!

Install WooCommerce from this ZIP file.

Regarding this step, I tested it installing the same zip generated by this PR twice. In any case, as @nefeline noted, it makes sense uploaded a zip file!

[albarin]

In this case you meant "checked", right?

@nefeline I think it's correct because the test is to confirm that patterns are fetched when it changes from unchecked to checked. So in step 1, we uncheck it, and then in step 2, we check it. Does it make sense?

@nefeline @gigitux Thanks for your reviews 🙏 I'll update the zip! 🤦

[nefeline]

@nefeline I think it's correct because the test is to confirm that patterns are fetched when it changes from unchecked to checked. So in step 1, we uncheck it, and then in step 2, we check it. Does it make sense?

🤔 maybe I'm missing something here, I think the title is not matching the content, is it?

Edit: nevermind, I missed step 2, all good 🙌