Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added title and subtitle testIds #7866

Merged
merged 8 commits into from
May 26, 2024
Merged

Conversation

Niryo
Copy link
Contributor

@Niryo Niryo commented Apr 14, 2024

Fixes #7879 according to the following formula:

Given a test ID top-bar-id over a screen's top-bar (specified either in the setRoot or screen's options), the following ID's are automatically set:

  • Title: top-bar-id.title
  • Subtitle: top-bar-id.subtitle

@d4vidi
Copy link
Collaborator

d4vidi commented Apr 15, 2024

Thanks dude! We're planning on follow up on that right after the holidays. I hope it's alright.

@d4vidi d4vidi self-assigned this Apr 15, 2024
@Niryo
Copy link
Contributor Author

Niryo commented May 6, 2024

@d4vidi can you take this?

@d4vidi
Copy link
Collaborator

d4vidi commented May 6, 2024

@d4vidi can you take this?

Yeah I'll take it in this sprint or the next one

@d4vidi d4vidi force-pushed the added-title-and-subtitle-testids branch from bbbf5b5 to d1d244b Compare May 22, 2024 10:55
@d4vidi d4vidi force-pushed the added-title-and-subtitle-testids branch from 10f1b6a to 19588ec Compare May 22, 2024 20:30
@d4vidi d4vidi merged commit f23bc2b into master May 26, 2024
4 checks passed
@d4vidi d4vidi deleted the added-title-and-subtitle-testids branch May 26, 2024 11:20
@d4vidi
Copy link
Collaborator

d4vidi commented May 27, 2024

@Niryo Released under 7.40.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Title and subtitle test ID's
3 participants