chore: use the sensible build... compatibly #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We try to use the "sensible" build when possible, handling all the old try/catch magic in catsrc. This mostly works, except for a problem in the parser that appears to be also present in my previous version: a huge object tries to reference things that don't exist. [The site is unchanged for now to avoid breaking any new things. Somebody added a // comment to CSS which is invalid, so expect it to not work. I did not break it.] The eslint rules are enabled. They don't really hit any package problems any more, so I figure it's time to turn them on. I added an rc for the tests so every complaint left is a true positive now. The Makefile has been rewritten to be aware of new changes. In the long run webpack would be the way to go still.
|
And who came up with the idea of committing built stuff to master anyways? |
|
Hi @Artoria2e5 Please make sure all the tests pass. Thanks! |
|
The failures are mainly due to new eslint rules being enabled. Confirm that you want these things fixed. (No false positives, so I guess it should be a go.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We try to use the "sensible" build when possible, handling all the old
try/catch magic in catsrc. This mostly works, except for a problem in
the parser that appears to be also present in a previous version: a
huge object tries to reference things that don't exist.
[The site is unchanged for now to avoid breaking any new things.
Somebody added a // comment to CSS which is invalid, so expect it to not
work. I did not break it.]
The eslint rules are enabled. They don't really hit any package problems
any more, so I figure it's time to turn them on. I added an rc for the
tests so every complaint left is a true positive now. FIxing them? not
my job.
The Makefile has been rewritten to be aware of new changes. In the long
run webpack would be the way to go still.