buflist: Do not hardcode colors in tls_version

[KaiserBarbarossa]

Do not hardcode the colors in buflist.format.tls_version

[ksu-0]

This incorrectly marks TLS 1.2 as deprecated. At the moment, deprecated versions are TLS 1.1 and earlier, and DTLS 1.0.

[KaiserBarbarossa]

This incorrectly marks TLS 1.2 as deprecated.

That’s what is done at the moment too and which was all introduced in #1622 (Suggested by this comment). As you can see here, too:

weechat/src/plugins/irc/irc-bar-item.c

Lines 562 to 564 in ad5fa7c

	case GNUTLS_TLS1_2:
	color = IRC_COLOR_ITEM_TLS_VERSION_DEPRECATED;
	break;

[flashcode]

@ksu-0: where can we check which versions of TLS are deprecated or not (today)?

[ksu-0]

The authoritative source for SSL 3.0 and newer, and for DTLS is the status of RFC that defines it. Moreover, each deprecation (including one for the never standardized SSL 2.0) was announced by RFC.

version	RFC	status	deprecation RFC
TLS 1.3	8446	proposed standard	—
TLS 1.2	5246	proposed standard	—
TLS 1.1	4346	historic (changed from proposed standard)	8996
TLS 1.0	2246	historic (changed from proposed standard)	8996
SSL 3.0	6101	historic	7568
SSL 2.0	—	expired draft	6176
DTLS 1.2	6347	proposed standard	—
DTLS 1.0	4347	historic (changed from proposed standard)	8996

[talisein]

My choice to use the word "deprecated" in the color option was imprecise. That color option is meant to draw attention to servers that are not using the latest TLS version but are still secure. The versions currently officially deprecated are denoted by the "insecure" color option.

I think this PR is good. Adjusting the color option name, if needed, can be done separately (this deprecated word is used elsewhere throughout the code for TLS 1.2).

[KaiserBarbarossa]

What about renaming "deprecated" to "elder"?