-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: migrate on acorn-import-attributes
#18251
base: main
Are you sure you want to change the base?
Conversation
For maintainers only:
|
Need to fix xtuc/acorn-import-attributes#31 (comment) |
Can I take this? 😁 |
@ahabhgk I am already working on it 😄 we have small problems here, need to deprecate the |
My opinion is deprecate the |
@ahabhgk Yeah, let's do it, I think |
@alexander-akait hello, is there any update on this? I'm very keen on this PR, because the old version of the acorn library is being flagged as containing a security issue. If there is any thing I can do to help this move along, then feel free to tag me in please. Cheers |
@alexandrenicol Hello, try to finish it on this week |
bedddc4
to
bbd3691
Compare
What kind of change does this PR introduce?
xtuc/acorn-import-attributes#31
Did you add tests for your changes?
Existing
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
Nothing